Michael Pasternak has posted comments on this change.
Change subject: core: change RemoveVmFromImportExportParamenters to get VM ID
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmsResource.java
Line 51:
Line 52: @Override
Line 53: public Response performRemove(String id) {
Line 54: RemoveVmFromImportExportParamenters params = new
RemoveVmFromImportExportParamenters(
Line 55: Guid.createGuidFromStringDefaultEmpty(id),
despite that this is a old code and this call is dispatched after get(), please
use asGuid(id) as it returns BAD_REQUEST while Guid.createGuidFromString()
throws IllegalArgumentException when string is not convertible to UUID
Line 56: storageDomainId,
Line 57: getDataCenterId(storageDomainId));
Line 58: return performAction(VdcActionType.RemoveVmFromImportExport,
params);
Line 59: }
--
To view, visit http://gerrit.ovirt.org/16707
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0fff20548248d3c47087d2d004d285c429a1c081
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
