Martin Sivák has posted comments on this change. Change subject: Use balloon_min to set the minimum guaranteed memory available ......................................................................
Patch Set 4: (1 inline comment) .................................................... File mom/Collectors/GuestBalloon.py Line 19: """ Line 20: This Collector uses hypervisor interface to collect guest balloon info Line 21: """ Line 22: def getFields(self=None): Line 23: return set(['balloon_cur', 'balloon_max', 'balloon_min']) I do not really agree. Although I see your point about putting the number into the policy. Unfortunately the guaranteed memory is VM related and follows the VM during migrations. So it is not really feasible to do it this way, especially with many thousands VM running in the cluster. Please see the libvirtInterface part of this patch that reads the value from the domain XML and makes it compatible. And now that I think about it, balloon_max is in the exact same situation as it is equal to the maximum memory the VM can get. And that is policy decision too. Line 24: Line 25: def __init__(self, properties): Line 26: self.hypervisor_iface = properties['hypervisor_iface'] Line 27: self.uuid = properties['uuid'] -- To view, visit http://gerrit.ovirt.org/15801 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I376ac6b2cdadc567314899a95c6b855f820e746b Gerrit-PatchSet: 4 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Martin Sivák <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
