Yair Zaslavsky has posted comments on this change.
Change subject: core: RFE-Adding External Tasks Support
......................................................................
Patch Set 8: (1 inline comment)
Something I missed before, sorry.
It's easy fix.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 1948: */
Line 1949: public Map<String, String> getJobMessageProperties() {
Line 1950: jobProperties = new HashMap<String, String>();
Line 1951: List<PermissionSubject> subjects =
getPermissionCheckSubjects();
Line 1952: if (jobProperties == null && subjects != null) {
Cannot be null, you initialized it two lines before. if should include only non
null suibjects check, and probably can be
if (subjects != null && !subjects.isEmpty() )
Line 1953: if (!subjects.isEmpty()) {
Line 1954: VdcObjectType entityType;
Line 1955: Guid entityId;
Line 1956: String value;
--
To view, visit http://gerrit.ovirt.org/15219
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I622e2a92b0433edbbf45fc4ed4f352cb2d09872d
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
