Zhou Zheng Sheng has posted comments on this change. Change subject: agent: Build and install ovirt guest agent on Ubuntu ......................................................................
Patch Set 10: I would prefer that you didn't submit this (2 inline comments) .................................................... File debian/ovirt-guest-agent.upstart Line 19: pre-start script Line 20: touch /var/run/ovirt-guest-agent.pid Line 21: chown ovirtagent:ovirtagent /var/run/ovirt-guest-agent.pid Line 22: chown ovirtagent:ovirtagent /var/log/ovirt-guest-agent Line 23: chown ovirtagent:ovirtagent /var/log/ovirt-guest-agent/ovirt-guest-agent.log I think this would be a problem if ovirt-guest-agent is installed in a new system. The log file does not exist and chown fails, so this initctl job fails to start. Can we change it to chown ovirtagent:ovirtagent /var/log/ovirt-guest-agent/ovirt-guest-agent.log || : to ignore this error? Line 24: end script Line 25: Line 26: exec sudo -u ovirtagent -g ovirtagent python /usr/share/ovirt-guest-agent/ovirt-guest-agent.py Line 27: .................................................... File ovirt-guest-agent/Makefile.am Line 21: $(NULL) Line 22: Line 23: dist_pkgdata_SCRIPTS= \ Line 24: hibernate \ Line 25: LockActiveSession.py \ It seems spaces are mixed with tabs here. Line 26: $(NULL) Line 27: Line 28: agentconfdir=$(sysconfdir) Line 29: agentconf_DATA=ovirt-guest-agent.conf -- To view, visit http://gerrit.ovirt.org/15313 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a694bf1f7ff4230bac305dd571899265ef63950 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
