Tomas Jelinek has posted comments on this change.
Change subject: webadmin,userportal: Upgrade GWT SDK and related modules
......................................................................
Patch Set 1: Looks good to me, approved
(2 inline comments)
Just one comment, otherwise I'm ok with the patch so giving +2.
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/IVdcQueryableCellTable.java
Line 32: * Table row data type.
Line 33: * @param <M>
Line 34: * List model type.
Line 35: */
Line 36: public class IVdcQueryableCellTable<T, M extends ListModel> extends
ColumnResizeCellTable<T> implements IsEditorDriver<M> {
This class has nothing to do with IVdcQueryable anymore. Please consider
renaming it accordingly. As it can edit any items maybe something like
GenericCellTable or ObjectCellTable?
Line 37:
Line 38: private static final int DEFAULT_PAGESIZE = 1000;
Line 39: private static final int CHECK_COLUMN_WIDTH = 27;
Line 40:
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/RxTxRateColumn.java
Line 17: @Override
Line 18: protected Double[] getRawValue(T object) {
Line 19: Double rate = object != null ? getRate(object) : null;
Line 20: Double speed = object != null ? getSpeed(object) : null;
Line 21: return new Double[] { rate, speed };
I would let it here - there are lots of implementations of getRate and getSpeed
so the null check would have to be in each of them. This is better I would say.
Line 22: }
Line 23:
Line 24: /**
Line 25: * Returns the Rx/Tx transfer rate.
--
To view, visit http://gerrit.ovirt.org/16739
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica797e68e2f56fd3f231baf36f0ac03c5df5c3f2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
