Adam Litke has posted comments on this change.

Change subject: Use min_guarantee to set the minimum guaranteed memory available
......................................................................


Patch Set 6: I would prefer that you didn't submit this

(1 inline comment)

I think there is a small bug due to changing balloon_min to min_guarantee

....................................................
File doc/balloon-qos.rules
Line 1: (def guest_qos (quest)
Line 2: {
Line 3:     (if (< guest.balloon_cur guest.min_guarantee)
Line 4:         (guest.Control "balloon_target" balloon_min) 0)
(guest.Control "balloon_target" guest.min_guarantee) 0) ?
Line 5: })
Line 6: 


-- 
To view, visit http://gerrit.ovirt.org/15801
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I376ac6b2cdadc567314899a95c6b855f820e746b
Gerrit-PatchSet: 6
Gerrit-Project: mom
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to