Itamar Heim has posted comments on this change.

Change subject: Added hook to add the external tracker
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File hooks/bz/patchset-created.bz.2.add_tracker
Line 3: # Adds an external bug to each bugzilla
Line 4: #
Line 5: # Config:
Line 6: #    TRACKER_ID
Line 7: #      Numeric id of the external tracker to add the bugs in, as seen 
in the 
whitespace
Line 8: #      bugzilla submit form.
Line 9: #        81 -> oVirt gerrit
Line 10: #        82 -> RHEV gerrit
Line 11: 
###############################################################################


Line 19:     # Get the bug url and it's flags
Line 20:     bz.login -b "$bug_id" "$bz_user" "$bz_password"
Line 21:     ## Update the tracker on the bz bug
Line 22:     local message="$(conf.t_get message)"
Line 23:     if ! bz.add_tracker "$bug_id" "${TRACKER_ID?}" 
"${change_url//*\/}"; then
where's the logic limiting this by bug current status and relevant products?
Line 24:         ## raise a warning error
Line 25:         message+="\n* Tracker #$bug_id: FAILED"
Line 26:         echo "WARNING: Failed to update tracker on bug #$bug_id for 
gerrit id #${change_url//*\/}"
Line 27:     else


-- 
To view, visit http://gerrit.ovirt.org/15912
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd5ba49d8a253a1fbd1ec6cd0073f53b47f81342
Gerrit-PatchSet: 1
Gerrit-Project: gerrit-admin
Gerrit-Branch: master
Gerrit-Owner: David Caro <[email protected]>
Gerrit-Reviewer: Eyal Edri <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ohad Basan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to