Michael Pasternak has posted comments on this change.
Change subject: core, restapi: cloud-init [2/6] - custom volume id in VM Payload
......................................................................
Patch Set 8: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 2063: <jaxb:property generateIsSetMethod="false"/>
Line 2064: </xs:appinfo>
Line 2065: </xs:annotation>
Line 2066: </xs:attribute>
Line 2067: <xs:attribute name="volume_id" type="xs:string"/>
1. this should be an element and not attribute
2. can you please give me some context on this attribute, i.e does it exist
somewhere in the system (i want to figure out if it should be referring
somewhere in api)
Line 2068: </xs:complexType>
Line 2069:
Line 2070: <xs:element name="payload_file" type="PayloadFile"/>
Line 2071:
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
Line 829: if (deviceType != null) {
Line 830: model.setType(deviceType.value());
Line 831: }
Line 832: }
Line 833: model.setVolumeId(entity.getVolumeId());
please update VmMapperTest accordingly
Line 834: for (Map.Entry<String, String> entry :
entity.getFiles().entrySet()) {
Line 835: PayloadFile file = new PayloadFile();
Line 836: file.setName(entry.getKey());
Line 837: file.setContent(entry.getValue());
Line 850: if (deviceType!=null) {
Line 851: entity.setType(map(deviceType, null));
Line 852: }
Line 853: }
Line 854: entity.setVolumeId(model.getVolumeId());
1. consider checking: if (model.isSetVolumeId())
2. please update VmMapperTest accordingly
Line 855: if (model.getFile() != null) {
Line 856: for (PayloadFile file : model.getFile()) {
Line 857: entity.getFiles().put(file.getName(),
file.getContent());
Line 858: }
--
To view, visit http://gerrit.ovirt.org/14349
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30a3be934869c62ed4cdd9942e7fe17af67572e0
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
