Allon Mureinik has posted comments on this change.
Change subject: backend: add the import glance image support
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(5 inline comments)
see questions inline.
The main point here is the revert flow - am I missing something?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCopyTaskHandler.java
Line 68: }
Line 69:
Line 70: @Override
Line 71: protected void revertTask() {
Line 72: // nothing to do
wouldn't we want to remove the image if the copy fails?
Line 73: }
Line 74:
Line 75: @Override
Line 76: public void endSuccessfully() {
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCreateTaskHandler.java
Line 21: import org.ovirt.engine.core.common.vdscommands.VDSReturnValue;
Line 22: import org.ovirt.engine.core.compat.Guid;
Line 23: import org.ovirt.engine.core.dal.dbbroker.DbFacade;
Line 24:
Line 25: import java.util.ArrayList;
please use the formatter - this should be at the top
Line 26:
Line 27:
Line 28: public class ImportRepoImageCreateTaskHandler implements
SPMAsyncTaskHandler {
Line 29:
Line 72: /* NullPointer Exception
Line 73: permissions perms = new
permissions(getCurrentUser().getUserId(),
Line 74: PredefinedRoles.DISK_OPERATOR.getId(),
diskImage.getId(), VdcObjectType.Disk);
Line 75: MultiLevelAdministrationHandler.addPermission(perms);
Line 76: */
huh?
Line 77: }
Line 78:
Line 79:
ExecutionHandler.setAsyncJob(enclosingCommand.getExecutionContext(), true);
Line 80: enclosingCommand.getReturnValue().setSucceeded(true);
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/OpenstackImageProviderProxy.java
Line 256: }
Line 257:
Line 258: ByteBuffer b = ByteBuffer.wrap(imgContent);
Line 259:
Line 260: if (b.getInt() == 0x514649fb && b.getInt() == 2) { // QCOW
version 2 signature and version check
please extract these constants
Line 261: b.position(24);
Line 262: return b.getLong();
Line 263: }
Line 264:
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportExportRepoImageCommandTest.java
Line 59:
Line 60: protected Guid diskImageGroupId;
Line 61:
Line 62: protected DiskImage diskImage;
Line 63:
can't all these be private?
Line 64: @Before
Line 65: public void setUp() {
Line 66: providerId = Guid.newGuid();
Line 67: repoStorageDomainId = Guid.newGuid();
--
To view, visit http://gerrit.ovirt.org/16082
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b3e9497b633bd2ad32b896aea0aaab80634f2a7
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
