Allon Mureinik has posted comments on this change.
Change subject: frontend: add glance storage domain support
......................................................................
Patch Set 6: (1 inline comment)
@Fede - see inline
@Einav - this patch contains a change in a KEY in a properties file.
Would you prefer it be changed for all the localized files (like was done
here), or be left alone?
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/DiskSizeRenderer.java
Line 21:
Line 22: @Override
Line 23: public String render(T size) {
Line 24: if (size == null || size.longValue() == 0) {
Line 25: return "NA"; //$NON-NLS-1$
should be N/A.
Also - shouldn't this be localized?
Line 26: }
Line 27:
Line 28: long sizeInGB = -1;
Line 29:
--
To view, visit http://gerrit.ovirt.org/15898
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I07274bbc14e52471242935fcf99b510469ec4abe
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
