Allon Mureinik has posted comments on this change.
Change subject: restapi: Adding support for copy/move disk from disk collection.
......................................................................
Patch Set 7: Looks good to me, but someone else must approve
(2 inline comments)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResource.java
Line 20: import javax.ws.rs.core.Response;
Line 21: import java.util.Collections;
Line 22:
Line 23: import static
org.ovirt.engine.api.restapi.resource.BackendVmDisksResource.SUB_COLLECTIONS;
Line 24:
Please fix your formatter to comply to project conventions.
This is just adding noise to the patch (especially since it's the only change
in this file)
Line 25:
Line 26: public class BackendVmDiskResource extends BackendDeviceResource<Disk,
Disks, org.ovirt.engine.core.common.businessentities.Disk> implements
VmDiskResource {
Line 27: protected BackendVmDiskResource(String id,
Line 28:
AbstractBackendReadOnlyDevicesResource<Disk, Disks,
org.ovirt.engine.core.common.businessentities.Disk> collection,
....................................................
File
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDiskResourceTest.java
Line 16: import org.ovirt.engine.core.compat.Guid;
Line 17:
Line 18: import javax.ws.rs.core.Response;
Line 19: import javax.ws.rs.core.UriInfo;
Line 20: import java.util.Collections;
Here too - please fix the formatting when you rebase.
Line 21:
Line 22: import static
org.ovirt.engine.api.restapi.resource.AbstractBackendDisksResourceTest.setUpEntityExpectations;
Line 23:
Line 24: public class BackendDiskResourceTest extends
AbstractBackendSubResourceTest<Disk,
org.ovirt.engine.core.common.businessentities.Disk, BackendDiskResource>{
--
To view, visit http://gerrit.ovirt.org/13973
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I516341d3e033a94a997ac5320312e75a5ed1576c
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
