Allon Mureinik has posted comments on this change.
Change subject: providers: add the openstack image support
......................................................................
Patch Set 6: Looks good to me, but someone else must approve
(2 inline comments)
basic +1 on the backend - some questions niline.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java
Line 187: StorageDomain storageDomain =
DbFacade.getInstance().getStorageDomainDao().get(storageDomainId);
Line 188:
Line 189: if (!forceRefresh) {
Line 190: return true;
Line 191: }
I'd move this to the top of the function.
No reason to make an additional DAO call if it's not going to be used.
Moreover - what's the point of call this function with forceRefresh=false?
Line 192:
Line 193: if (storageDomain.getStorageDomainType() ==
StorageDomainType.ISO) {
Line 194: refreshResult = refreshIsoDomain(storageDomainId,
tempProblematicRepoFileList, imageType);
Line 195: } else if (storageDomain.getStorageDomainType() ==
StorageDomainType.Image &&
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/OpenstackImageProviderProxy.java
Line 85: public List<? extends Certificate> getCertificateChain() {
Line 86: return null;
Line 87: }
Line 88:
Line 89: protected static DbFacade getDbFacade() {
can'y this be made private?
Line 90: return DbFacade.getInstance();
Line 91: }
Line 92:
Line 93: @Override
--
To view, visit http://gerrit.ovirt.org/15899
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I424998de6f6514d65938484fffa5405e35857e43
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
