Michael Pasternak has posted comments on this change.
Change subject: restapi: copy template permissions REST part
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
Line 124: vm.high_availability.enabled: xs:boolean
Line 125: vm.domain.name: xs:string
Line 126: vm.description: xs:string
Line 127: vm.stateless: xs:boolean
Line 128: vm.permissions.clone: xs:boolean
please add it to other signatures of vm.add()
Line 129: vm.delete_protected: xs:boolean
Line 130: vm.cpu.mode: xs:string
Line 131: vm.cpu.topology.sockets: xs:int
Line 132: vm.placement_policy.affinity: xs:string
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java
Line 229: if (vm.isSetMemoryPolicy() &&
vm.getMemoryPolicy().isSetBallooning()) {
Line 230:
params.setBalloonEnabled(vm.getMemoryPolicy().isBallooning());
Line 231: }
Line 232:
params.setMakeCreatorExplicitOwner(shouldMakeCreatorExplicitOwner());
Line 233: setupCloneTemplatePermissions(vm, params);
please see comment for createVmFromSnaphsot in PS-3
Line 234: return performCreate(VdcActionType.AddVmFromTemplate,
Line 235: params,
Line 236: new
QueryIdResolver<Guid>(VdcQueryType.GetVmByVmId, IdQueryParameters.class));
Line 237: }
....................................................
Commit Message
Line 10: it is possible to specify the template.copy_permissions or
Line 11: vm.copy_permissions boolean parameter
Line 12: to copy the template (VM) permissions to the newly created
Line 13: VM (template).
Line 14:
please update comment according to the new representation in api
Line 15: Change-Id: I64a0bc3d30cf5ccfb08efe1d02e1c9466d01fe66
--
To view, visit http://gerrit.ovirt.org/16199
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I64a0bc3d30cf5ccfb08efe1d02e1c9466d01fe66
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
