Michael Pasternak has posted comments on this change.
Change subject: core, restapi, webadmin, userportal: cloud-init [3/6] - backend
......................................................................
Patch Set 9: (1 inline comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java
Line 245: params.setInitializationType(InitializationType.Sysprep);
Line 246: } else if
(SimpleDependecyInjector.getInstance().get(OsRepository.class).isLinux(vm.getVmOsId())
&& params.getCloudInitParameters() != null) {
Line 247:
params.setInitializationType(InitializationType.CloudInit);
Line 248: } else {
Line 249: params.setInitializationType(InitializationType.None);
consider adding test checking this flow
Line 250: }
Line 251: return params;
Line 252: }
Line 253:
--
To view, visit http://gerrit.ovirt.org/14350
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida8ffa5b92ff79cdac5e401c0a815ffcf517590d
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Martin Betak <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches