Maor Lipchuk has posted comments on this change. Change subject: core: Remove hyphen from non-responsive for Data Center ......................................................................
Patch Set 5: (1 inline comment) .................................................... File frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties Line 16: StoragePoolStatus___Notconfigured=Not Configured Line 17: StoragePoolStatus___Uninitialized=Uninitialized Line 18: StoragePoolStatus___Up=Up Line 19: StoragePoolStatus___NotOperational=Not Operational Line 20: StoragePoolStatus___Problematic=Non Responsive 1.In the rest it is currently called problematic. it is being used when we list the data centers (localhost:8080/api/datacenters) 2. no problem of changing the enum, but we will still have DataCenterStatus in the api.model which will still reflect the problematic state there. I will send a separate patch which will change the enum key in the engine Line 21: StoragePoolStatus___Contend=Contending Line 22: StorageType___ALL=All Line 23: StorageType___FCP=Fibre Channel Line 24: StorageType___ISCSI=iSCSI -- To view, visit http://gerrit.ovirt.org/16667 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12df92b594850bff145a9383fa9eaf0138004b8e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
