Omer Frenkel has posted comments on this change.
Change subject: engine: improve logging in gluster sync job
......................................................................
Patch Set 3: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java
Line 125: }
Line 126:
Line 127: acquireLock(cluster.getId());
Line 128:
Line 129: log.infoFormat("Refreshing Gluster Server data for cluster
{0} using server {1} ",
iiuc, this will write to the log every 5 sec, which might flood it, i think its
better to have this as debug/trace
Line 130: cluster.getName(),
Line 131: upServer.getName());
Line 132: try {
Line 133: List<GlusterServerInfo> fetchedServers =
fetchServers(cluster, upServer, existingServers);
Line 157: log.errorFormat("Error while removing server {0}
from database!", server.getName(), e);
Line 158: }
Line 159: }
Line 160: }
Line 161: if (serverRemoved) {
why this log is needed, if the above will appear for each removed server?
Line 162: log.infoFormat("Servers detached using gluster CLI is
removed from engine after inspecting the Gluster servers list {0}",
Line 163: fetchedServers);
Line 164: }
Line 165: }
Line 247: return null;
Line 248: }
Line 249:
Line 250: if (fetchedServers.size() == 1 && existingServers.size() > 2)
{
Line 251: log.infoFormat("Gluster servers list fetched from server
{0} has only one server", upServer.getName());
wouldn't it also be printed too much? maybe use debug
Line 252: // It's possible that the server we are using to get list
of servers itself has been removed from the
Line 253: // cluster, and hence is returning a single server
(itself)
Line 254: GlusterServerInfo server =
fetchedServers.iterator().next();
Line 255: if (isSameServer(upServer, server)) {
Line 296: */
Line 297: private List<GlusterServerInfo> fetchServers(VDS upServer,
List<VDS> existingServers) {
Line 298: List<GlusterServerInfo> fetchedServers = null;
Line 299: while (fetchedServers == null && !existingServers.isEmpty()) {
Line 300: log.infoFormat("Fetching gluster servers list from server
{0}", upServer.getName());
also
Line 301: fetchedServers = fetchServers(upServer);
Line 302: if (fetchedServers == null) {
Line 303: log.infoFormat("Gluster servers list failed in server
{0} moving it to NonOperational",
Line 304: upServer.getName());
--
To view, visit http://gerrit.ovirt.org/16712
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie07ba4447366915e0a9d487d241ea1ae9927a196
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
