Omer Frenkel has posted comments on this change.
Change subject: core: [logging] Remove redundant VDS in logs
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
Line 300: }
Line 301: }
Line 302:
Line 303: private void logFailureMessage(RuntimeException ex) {
Line 304: log.warnFormat("Failed to refresh info - error = '{0}',
continuing.", ex);
is the new logging also logs host name+id?
Line 305: }
Line 306:
Line 307: private static void logException(final RuntimeException ex) {
Line 308: log.error(ex);
Line 303: private void logFailureMessage(RuntimeException ex) {
Line 304: log.warnFormat("Failed to refresh info - error = '{0}',
continuing.", ex);
Line 305: }
Line 306:
Line 307: private static void logException(final RuntimeException ex) {
i think its good time to remove this method
Line 308: log.error(ex);
Line 309: }
Line 310:
Line 311: private void logAfterRefreshFailureMessage(RuntimeException ex) {
--
To view, visit http://gerrit.ovirt.org/16558
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id51e00d565e9e6de60d0780217e23dff027ca2f3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
