Alona Kaplan has posted comments on this change.
Change subject: webadmin: Redesigned Add/Edit Network
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java
Line 108: setPublicUse(publicUse);
Line 109:
Line 110: // Update changeability according to initial values
Line 111: onExportChanged();
Line 112: updateVlanTagChangeability();
This order is problematic. If you have external network and for example vlan
tag is true then the vlan text box will be enabled even it shouldn't.
Line 113: updateMtuChangeability();
Line 114: }
Line 115:
Line 116: public EntityModel getName()
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkListModel.java
Line 75:
Line 76: final NetworkModel networkModel = new NewNetworkModel(this);
Line 77: setWindow(networkModel);
Line 78:
Line 79: networkModel.startProgress(null);
Why do you do it here and not as part of the initDcList()?
Line 80: initDcList(networkModel);
Line 81: }
Line 82:
Line 83: public void importNetworks() {
Line 98:
Line 99: final NetworkModel networkModel = new
EditNetworkModel(network, this);
Line 100: setWindow(networkModel);
Line 101:
Line 102: networkModel.startProgress(null);
same
Line 103: initDcList(networkModel);
Line 104:
Line 105: }
Line 106:
--
To view, visit http://gerrit.ovirt.org/16804
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I25b5533a41358d51b959f94f36e390f56f630d93
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
