Alon Bar-Lev has posted comments on this change. Change subject: pki: Allow changing the manager hostname ......................................................................
Patch Set 17: I would prefer that you didn't submit this Sorry... marking my vote as -1. 1. Sent offline an example of how uninstall should be implemented in shell, if you think shell is not the right tool, please re-write it in different tool, but do not leave the complexity. 2. Please take care of the rename of all .sh scripts to script without suffix, I don't we break conventions in one patch. 3. Throughout the 3.3 release cycle, I tried to push high standards and conventions into the packaging subcomponent, so far I succeeded. I understand that I may push too hard, however, I did not expect this start to collapse before the release of 3.3. -- To view, visit http://gerrit.ovirt.org/16404 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb03d638be1e030865d3ebabaa163ca9be9e70ce Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
