Yaniv Bronhaim has posted comments on this change. Change subject: core: host-deploy: Applying usage for public key authentication method ......................................................................
Patch Set 9: (1 inline comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ApproveVdsParameters.java Line 10 Line 11 Line 12 Line 13 Line 14 basically you right, and i tested it and it does get called, but when i remove it i get RegisterVdsQuery.java:[225,44] error: constructor ApproveVdsParameters in class ApproveVdsParameters cannot be applied to given types; , so i created the empty constructor that call to super, and then i get error on InstallVdsParameters, so I created in each of them the default const. and even if it is right, what's so wrong in keeping the implementation of default const, even if its redundant, its easier to read imho. -- To view, visit http://gerrit.ovirt.org/16688 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51f2566f91935a74504785a6e62d66b765dfa671 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
