Omer Frenkel has posted comments on this change.

Change subject: core, restapi: cloud-init [1/6] - multiple files in VM Payload
......................................................................


Patch Set 9: (1 inline comment)

....................................................
File 
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 2116:   <xs:element name="payload" type="Payload"/>
Line 2117: 
Line 2118:   <xs:complexType name="Payload">
Line 2119:     <xs:sequence>
Line 2120:       <xs:element name="file" type="PayloadFile" minOccurs="0" 
maxOccurs="unbounded"/>
I agree, in addition, there might be a case where user set payload just to have 
the device in the vm (empty payload).
maybe it doesn't make sense but i dont see a reason to block it
Line 2121:     </xs:sequence>
Line 2122:     <xs:attribute name="type" type="xs:string">
Line 2123:         <xs:annotation>
Line 2124:           <xs:appinfo>


-- 
To view, visit http://gerrit.ovirt.org/14348
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I70934b8013459037f3d56573f80915bfa6b42bb4
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to