Sandro Bonazzola has uploaded a new change for review.

Change subject: packaging: setup: moved vm run at closeup
......................................................................

packaging: setup: moved vm run at closeup

Moved VM execution at closeup stage with low priority
for having the firewall configured and ports opened.

Change-Id: I079ab041acfe28f9376bfbb052be9307842c2a36
Signed-off-by: Sandro Bonazzola <[email protected]>
---
M src/plugins/ovirt-hosted-engine-setup/engine/os_install.py
M src/plugins/ovirt-hosted-engine-setup/vm/runvm.py
2 files changed, 6 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-hosted-engine-setup 
refs/changes/78/16878/1

diff --git a/src/plugins/ovirt-hosted-engine-setup/engine/os_install.py 
b/src/plugins/ovirt-hosted-engine-setup/engine/os_install.py
index f2fd7b9..92dca29 100644
--- a/src/plugins/ovirt-hosted-engine-setup/engine/os_install.py
+++ b/src/plugins/ovirt-hosted-engine-setup/engine/os_install.py
@@ -49,7 +49,7 @@
         super(Plugin, self).__init__(context=context)
 
     @plugin.event(
-        stage=plugin.Stages.STAGE_MISC,
+        stage=plugin.Stages.STAGE_CLOSEUP,
         after=[
             ohostedcons.Stages.VM_RUNNING,
         ],
diff --git a/src/plugins/ovirt-hosted-engine-setup/vm/runvm.py 
b/src/plugins/ovirt-hosted-engine-setup/vm/runvm.py
index a94d9fb..ada27df 100644
--- a/src/plugins/ovirt-hosted-engine-setup/vm/runvm.py
+++ b/src/plugins/ovirt-hosted-engine-setup/vm/runvm.py
@@ -240,16 +240,13 @@
                     )
 
     @plugin.event(
-        stage=plugin.Stages.STAGE_MISC,
-        after=[
-            ohostedcons.Stages.VM_CONFIGURED,
-            ohostedcons.Stages.VM_IMAGE_AVAILABLE,
-            ohostedcons.Stages.LIBVIRT_CONFIGURED,
-            ohostedcons.Stages.SSHD_START,
-        ],
+        stage=plugin.Stages.STAGE_CLOSEUP,
         name=ohostedcons.Stages.VM_RUNNING,
+        priority=plugin.Stages.PRIORITY_LOW,
     )
     def _boot_from_install_media(self):
+        #Need to be done after firewall closeup for allowing the user to
+        #connect from remote.
         os_installed = False
         while not os_installed:
             self._create()
@@ -302,7 +299,7 @@
                 raise RuntimeError('OS installation aborted by user')
 
     @plugin.event(
-        stage=plugin.Stages.STAGE_MISC,
+        stage=plugin.Stages.STAGE_CLOSEUP,
         after=[
             ohostedcons.Stages.OS_INSTALLED,
         ],


-- 
To view, visit http://gerrit.ovirt.org/16878
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I079ab041acfe28f9376bfbb052be9307842c2a36
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to