Kanagaraj M has posted comments on this change.

Change subject: engine: Host activate -check gluster availability
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
Line 582:                     vds.setStatus(VDSStatus.NonOperational);
Line 583:                     
vds.setNonOperationalReason(NonOperationalReason.GLUSTER_COMMAND_FAILED);
Line 584:                     returnStatus = vds.getStatus();
Line 585:                 }
Line 586:             }
Can this be moved to GlusterMonitoringStrategy.processSoftwareCapabilities()?
Line 587: 
Line 588:             // We process the software capabilities.
Line 589:             VDSStatus oldStatus = vds.getStatus();
Line 590:             monitoringStrategy.processSoftwareCapabilities(vds);


-- 
To view, visit http://gerrit.ovirt.org/16898
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If673e32ed6480187ddcf6f9ecf8f0007e203b98d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to