Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: allow db cleanup on errors ......................................................................
Patch Set 1: Well... I see several problems... 1. provisioning makes no assumptions it always creates a new database if non empty. 2. as clear does not actually drop the database, if database exists and empty provisioning should be much faster at second time. 3. if we do not clear database, we may have dirty database when user attempt to run setup again without cleanup. -- To view, visit http://gerrit.ovirt.org/16869 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb2a9d7e1c0a318d0bbbf45b2d584245d634fc02 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
