Martin Peřina has posted comments on this change.
Change subject: core: Use VdsValidator in canDoAction of ActivateVds
......................................................................
Patch Set 6: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsValidator.java
Line 66: if (!existsValidation.isValid()) {
Line 67: return existsValidation;
Line 68: }
Line 69: if (VDSStatus.Up == vds.getStatus()) {
Line 70: return new ValidationResult(VdcBllMessages.VDS_ALREADY_UP);
Well, I prefer reversed notation with ==
if (vds.getStatus() == VDSStatus.Up) {
it make more sense to me, but it's a minor thing.
Line 71: }
Line 72: return ValidationResult.VALID;
Line 73: }
Line 74:
--
To view, visit http://gerrit.ovirt.org/16649
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9a887de27757cd8ff89c8d68eb916be68d327fd
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
