Yair Zaslavsky has posted comments on this change.
Change subject: core: Add the ability to create a dummy task in case of VDSM
failure
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java
Line 785: }
Line 786:
Line 787: return false;
Line 788: }
Line 789:
Of course.
Line 790: public static void logAndFailTaskOfCommandWithEmptyVdsmId(Guid
asyncTaskId, String message) {
Line 791: AsyncTasks task =
DbFacade.getInstance().getAsyncTaskDao().get(asyncTaskId);
Line 792: logAndFailTaskOfCommandWithEmptyVdsmId(task, message);
Line 793: }
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 371:
Line 372: private void clearAsyncTasksWithOutVdsmId() {
Line 373: for (Guid asyncTaskId :
getReturnValue().getTaskPlaceHolderIdList()) {
Line 374: AsyncTasks task = getAsyncTaskDao().get(asyncTaskId);
Line 375: if (task != null &&
Guid.isNullOrEmpty(task.getVdsmTaskId())) {
I'll add logging.
Line 376:
AsyncTaskManager.removeTaskFromDbByTaskId(task.getTaskId());
Line 377: }
Line 378: }
Line 379: }
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandMultiAsyncTasks.java
Line 55: java.util.ArrayList<CommandAsyncTask>
CurrentActionTypeTasks = getCurrentTasks();
Line 56:
Line 57: for (CommandAsyncTask task : CurrentActionTypeTasks) {
Line 58: // Check this is a task that is run on VDSM and is not
in ENDED state.
Line 59: if (task.getState() != AsyncTaskState.Ended &&
!task.getVdsmTaskId().equals(Guid.Empty)) {
Thanks for your comments guys
Line 60: log.infoFormat("Task ID: '{0}' is in state {1}.
End action for command {2} will proceed when all the entity's tasks are
completed.",
Line 61: task.getVdsmTaskId(),
Line 62: task.getState(),
Line 63: getCommandId());
--
To view, visit http://gerrit.ovirt.org/16642
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e977596af52c81a1aed1b8748a30b9425c62fa3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
