Moti Asayag has uploaded a new change for review. Change subject: engine: Create a vnic profile implicitly when adding network ......................................................................
engine: Create a vnic profile implicitly when adding network The patch creates a vnic profile for a newly created network unless the client requested specifically not to. The purpose of the patch is to allow same flow of: create network and use the network by a VMs to function the same without demanding a user to add another step of creating the profile. The created profile will carry the same network name and will not contain any attributes (no port mirroring, no custom properties). Change-Id: Ie8adb307aad864089cbccd5e05d8fc591b6cce60 Signed-off-by: Moti Asayag <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/AddNetworkCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddNetworkStoragePoolParameters.java 2 files changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/91/16991/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/AddNetworkCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/AddNetworkCommand.java index bf947fa..a22ff4e 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/AddNetworkCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/AddNetworkCommand.java @@ -26,6 +26,7 @@ protected void executeCommand() { getNetwork().setId(Guid.newGuid()); getNetworkDAO().save(getNetwork()); + getVnicProfileDao().save(NetworkHelper.createVnicProfile(getNetwork())); NetworkHelper.addPermissionsOnNetwork(getCurrentUser().getUserId(), getNetwork().getId()); getReturnValue().setActionReturnValue(getNetwork().getId()); setSucceeded(true); diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddNetworkStoragePoolParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddNetworkStoragePoolParameters.java index 15dea0c..dba2837 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddNetworkStoragePoolParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddNetworkStoragePoolParameters.java @@ -13,6 +13,8 @@ @NotNull private Network network; + private boolean vnicProfileRequired = true; + public AddNetworkStoragePoolParameters() { } @@ -24,4 +26,12 @@ public Network getNetwork() { return network; } + + public boolean isVnicProfileRequired() { + return vnicProfileRequired; + } + + public void setVnicProfileRequired(boolean vnicProfileRequired) { + this.vnicProfileRequired = vnicProfileRequired; + } } -- To view, visit http://gerrit.ovirt.org/16991 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie8adb307aad864089cbccd5e05d8fc591b6cce60 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
