Allon Mureinik has posted comments on this change.
Change subject: backend: add the export glance image support
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(3 inline comments)
Other than the merged conflict in
backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties,
everything looks fine.
Please verify so it can be merged.
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 248: <<<<<<< HEAD
Line 249: VAR__TYPE__SPM=$type SPM
Line 250: =======
Line 251: VAR__TYPE__CLUSTER_POLICY=$type Cluster Policy
Line 252: >>>>>>> engine: cluster policy commands and queries
Probably a rebase FOOBAR - please fix.
Line 253: VAR__ACTION__RUN=$action run
Line 254: VAR__ACTION__REMOVE=$action remove
Line 255: VAR__ACTION__ADD=$action add
Line 256: VAR__ACTION__CREATE=$action create
Line 937: ACTION_TYPE_FAILED_CLUSTER_POLICY_FILTER_NOT_IMPLEMENTED=Cannot
${action} ${type}. Policy unit doesn't implement Filtering.
Line 938: ACTION_TYPE_FAILED_CLUSTER_POLICY_FUNCTION_NOT_IMPLEMENTED=Cannot
${action} ${type}. Policy unit doesn't implement score function.
Line 939: ACTION_TYPE_FAILED_CLUSTER_POLICY_BALANCE_NOT_IMPLEMENTED=Cannot
${action} ${type}. Policy unit doesn't implement load balancing logic.
Line 940: ACTION_TYPE_FAILED_CLUSTER_POLICY_ONLY_ONE_FILTER_CAN_BE_FIRST=Cannot
${action} ${type}. Only a single filter can be selected as first.
Line 941: ACTION_TYPE_FAILED_CLUSTER_POLICY_ONLY_ONE_FILTER_CAN_BE_LAST=Cannot
${action} ${type}. Only a single filter can be selected as last.
please remove TWS
Line 942: ACTION_TYPE_FAILED_CLUSTER_POLICY_FUNCTION_FACTOR_NEGATIVE=Cannot
${action} ${type}. Function factor cannot be negative.
Line 943:
Line 944: # External Events Errors Messages
Line 945: VAR__TYPE__EXTERNAL_EVENT=$type External Event
....................................................
File
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Line 914: ACTION_TYPE_FAILED_CLUSTER_POLICY_FILTER_NOT_IMPLEMENTED=Cannot
${action} ${type}. Policy unit doesn't implement Filtering.
Line 915: ACTION_TYPE_FAILED_CLUSTER_POLICY_FUNCTION_NOT_IMPLEMENTED=Cannot
${action} ${type}. Policy unit doesn't implement score function.
Line 916: ACTION_TYPE_FAILED_CLUSTER_POLICY_BALANCE_NOT_IMPLEMENTED=Cannot
${action} ${type}. Policy unit doesn't implement load balancing logic.
Line 917: ACTION_TYPE_FAILED_CLUSTER_POLICY_ONLY_ONE_FILTER_CAN_BE_FIRST=Cannot
${action} ${type}. Only a single filter can be selected as first.
Line 918: ACTION_TYPE_FAILED_CLUSTER_POLICY_ONLY_ONE_FILTER_CAN_BE_LAST=Cannot
${action} ${type}. Only a single filter can be selected as last.
Please remove TWS
Line 919: ACTION_TYPE_FAILED_CLUSTER_POLICY_FUNCTION_FACTOR_NEGATIVE=Cannot
${action} ${type}. Function factor cannot be negative.
Line 920:
Line 921: # External Events Errors Messages
Line 922: VAR__TYPE__EXTERNAL_EVENT=$type External Event
--
To view, visit http://gerrit.ovirt.org/16419
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id93d40ebb812e4be8669ad14f6ba92aab4de28ac
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
