Shubhendu Tripathi has posted comments on this change.
Change subject: engine: Add remove vnic profile command
......................................................................
Patch Set 12: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/RemoveVnicProfileCommand.java
Line 48: }
Line 49:
Line 50: @Override
Line 51: protected void executeCommand() {
Line 52: getVnicProfileDao().remove(getVnicProfile().getId());
Minor: getVnicProfile() is getting called multiple times here. Can think of
declaring as a final variable class level for the same.
Line 53: setSucceeded(true);
Line 54: }
Line 55:
Line 56: @Override
--
To view, visit http://gerrit.ovirt.org/16676
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I53d8803f78838cea6c8423cb95b6d12ce6d3bea0
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
