Moti Asayag has posted comments on this change.
Change subject: engine: Add update vnic profile command
......................................................................
Patch Set 12: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVnicProfileCommand.java
Line 67: }
Line 68:
Line 69: @Override
Line 70: protected void executeCommand() {
Line 71: getVnicProfileDao().update(getVnicProfile());
Thanks for the review.
Please see the following class from a patch after some refactor:
http://gerrit.ovirt.org/#/c/16887/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVnicProfileCommand.java
The shared validation logic was extracted into a share class, so the class
looks cleaner.
Line 72: setSucceeded(true);
Line 73: }
Line 74:
Line 75: @Override
--
To view, visit http://gerrit.ovirt.org/16675
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a666ccc4fc259c28e56e1c0c455fdd9b0ad14b7
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
