ofri masad has uploaded a new change for review. Change subject: core: remove permission check for released quota ......................................................................
core: remove permission check for released quota Removed the permission check for released quota. A user should be able to release a quota even he is not a consumer of that quota. Change-Id: Iec530af23b1e6d41aa9b97ff6337fd4eb48d947a Bug-Url: https://bugzilla.redhat.com/965622 Signed-off-by: Ofri Masad <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/24/17024/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java index 3e6d577..9152f7f 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java @@ -1037,7 +1037,8 @@ if (consumptionParameters != null) { for (QuotaConsumptionParameter parameter : getQuotaConsumptionParameters()) { - if (parameter.getQuotaGuid() != null && !Guid.Empty.equals(parameter.getQuotaGuid())) { + if (parameter.getQuotaGuid() != null && !Guid.Empty.equals(parameter.getQuotaGuid()) + && parameter.getQuotaAction().equals(QuotaConsumptionParameter.QuotaAction.CONSUME)) { quotaPermissionList.add(new PermissionSubject(parameter.getQuotaGuid(), VdcObjectType.Quota, ActionGroup.CONSUME_QUOTA)); } } -- To view, visit http://gerrit.ovirt.org/17024 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iec530af23b1e6d41aa9b97ff6337fd4eb48d947a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
