Vojtech Szocs has posted comments on this change.
Change subject: core: i18n welcome page with branding
......................................................................
Patch Set 6: (2 inline comments)
> Regarding the overriding option. If that is something that we get demand for
> it should be very easy to add at some later point in time. For now what this
> does is sufficient for our needs.
Sounds good, I didn't know if we really need the overriding option now, it was
just an idea.
....................................................
File backend/manager/modules/root/src/main/webapp/WEB-INF/ovirt-engine.jsp
Line 33: <div class="welcome"><fmt:message key="welcome.text" /></div>
Line 34: <div class="welcome">
Line 35: <script type="text/JavaScript">
Line 36: <!--
Line 37: document.write('<fmt:message key="version"><fmt:param
value="myVersion" /> </fmt:message>')
In both WebAdmin & UserPortal "About" dialog, we determine the version via
public query - AsyncDataProvider.getRpmVersionViaPublic method.
I guess you can inject BackendLocal interface via @EJB into WelcomeServlet to
invoke this query, similar to how GwtDynamicHostPageServlet injects
BackendLocal interface.
Line 38: //-->
Line 39: </script>
Line 40: </div>
Line 41:
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/branding/BrandingManager.java
Line 247: while (keyMatcher.find()) {
Line 248: String key = keyMatcher.group(1);
Line 249: replacedTemplate = replacedTemplate.replaceAll("\\{"
+ key + "\\}", messageMap.get(key));
Line 250: }
Line 251: replacedTemplate = replacedTemplate.replaceAll("\\{0\\}",
locale.toString());
Maybe I'm missing something but I can't see this mentioned in any properties
file.
But since this has to do with welcome_page.template processing, maybe it should
be just mentioned within README.branding "WELCOME PAGE TEMPLATE" section,
instead of in properties file.
Line 252: templateBuilder.append(replacedTemplate);
Line 253: }
Line 254: return templateBuilder.toString();
Line 255: }
--
To view, visit http://gerrit.ovirt.org/16359
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9987ed58c2e0ead9b25c5f46fb974a96bfd46d30
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
