Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Upgrade GWT SDK and related modules
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.java
Line 132: @WithElementId("runAndPause")
Line 133: EntityModelCheckBoxEditor runAndPauseEditor;
Line 134:
Line 135: @UiField
Line 136: @Path(value = "kernel_path.entity")
Indeed, but if @Path value isn't correct, GWT compilation / Maven build will
fail, anyway.
Line 137: @WithElementId("kernelPath")
Line 138: EntityModelTextBoxEditor kernelPathEditor;
Line 139:
Line 140: @UiField
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.ui.xml
Line 51: </g:VerticalPanel>
Line 52: <t:DialogTabPanel ui:field="dialogTabPanel"
height="340px" width="100%" addStyleNames="{style.tabPanel}">
Line 53: <t:tab>
Line 54: <t:DialogTab ui:field="targetsToLunTab">
Line 55: <t:content>
OK, let me know if there is any regression, but AFAIK height="100%" on
<t:content> doesn't have any real effect (but I can be wrong).
In any case, height="100%" on <t:content> breaks GWT compilation so if there's
indeed some regression, we'll need to apply height="100%" in a different way,
e.g. via some DIV element.
Line 56: <w:ValidatedPanelWidget
ui:field="targetsToLunsPanel" addStyleNames="{style.tabContentPanel}" />
Line 57: </t:content>
Line 58: </t:DialogTab>
Line 59: </t:tab>
--
To view, visit http://gerrit.ovirt.org/16739
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica797e68e2f56fd3f231baf36f0ac03c5df5c3f2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
