Alon Bar-Lev has uploaded a new change for review. Change subject: packaging: setup: iptables port range separator is ':' ......................................................................
packaging: setup: iptables port range separator is ':' Change-Id: Ifcd76e93ab30145ca563a8f54eb2b88ea1e97f11 Signed-off-by: Alon Bar-Lev <[email protected]> Reported-By: Hetz Ben Hamo <[email protected]> --- M packaging/setup/plugins/ovirt-engine-setup/network/firewall_manager.py 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/36/17036/1 diff --git a/packaging/setup/plugins/ovirt-engine-setup/network/firewall_manager.py b/packaging/setup/plugins/ovirt-engine-setup/network/firewall_manager.py index 5f3cf37..d613626 100644 --- a/packaging/setup/plugins/ovirt-engine-setup/network/firewall_manager.py +++ b/packaging/setup/plugins/ovirt-engine-setup/network/firewall_manager.py @@ -43,7 +43,7 @@ Firewall manager selection plugin. """ - def _parseFirewalld(self, format): + def _parseFirewalld(self, format, portSeparator='-'): ret = '' for content in [ content @@ -61,7 +61,7 @@ for node in nodes: ret += format.format( protocol=node.prop('protocol'), - port=node.prop('port'), + port=node.prop('port').replace('-', portSeparator), ) finally: if doc is not None: @@ -79,7 +79,8 @@ format=( '-A INPUT -p {protocol} -m state --state NEW ' '-m {protocol} --dport {port} -j ACCEPT\n' - ) + ), + portSeparator=':', ) } ) -- To view, visit http://gerrit.ovirt.org/17036 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifcd76e93ab30145ca563a8f54eb2b88ea1e97f11 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
