Gilad Chaplik has uploaded a new change for review. Change subject: core: dao guid optimizations ......................................................................
core: dao guid optimizations usage of getGuid instead of manipulating a string in cluster policy and policy unit DAOs. Change-Id: Ib869b2aeabf934913375642a183fb3af64342f9b Signed-off-by: Gilad Chaplik <[email protected]> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/scheduling/ClusterPolicyDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/scheduling/PolicyUnitDaoImpl.java 2 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/46/17046/1 diff --git a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/scheduling/ClusterPolicyDaoImpl.java b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/scheduling/ClusterPolicyDaoImpl.java index 4f1bd44..22c18fd 100644 --- a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/scheduling/ClusterPolicyDaoImpl.java +++ b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/scheduling/ClusterPolicyDaoImpl.java @@ -153,8 +153,8 @@ @Override public ClusterPolicyUnit mapRow(ResultSet rs, int arg1) throws SQLException { ClusterPolicyUnit unit = new ClusterPolicyUnit(); - unit.setClusterPolicyId(Guid.createGuidFromString(rs.getString("cluster_policy_id"))); - unit.setPolicyUnitId(Guid.createGuidFromString(rs.getString("policy_unit_id"))); + unit.setClusterPolicyId(getGuid(rs, "cluster_policy_id")); + unit.setPolicyUnitId(getGuid(rs, "policy_unit_id")); unit.setFilterSelected(rs.getBoolean("is_filter_selected")); unit.setFilterSequence(rs.getInt("filter_sequence")); unit.setFunctionSelected(rs.getBoolean("is_function_selected")); @@ -199,7 +199,7 @@ @Override public ClusterPolicy mapRow(ResultSet rs, int arg1) throws SQLException { ClusterPolicy clusterPolicy = new ClusterPolicy(); - clusterPolicy.setId(Guid.createGuidFromString(rs.getString("id"))); + clusterPolicy.setId(getGuid(rs, "id")); clusterPolicy.setName(rs.getString("name")); clusterPolicy.setDescription(rs.getString("description")); clusterPolicy.setLocked(rs.getBoolean("is_locked")); diff --git a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/scheduling/PolicyUnitDaoImpl.java b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/scheduling/PolicyUnitDaoImpl.java index 6e0ba30..346b828 100644 --- a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/scheduling/PolicyUnitDaoImpl.java +++ b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/scheduling/PolicyUnitDaoImpl.java @@ -41,7 +41,7 @@ @Override public PolicyUnit mapRow(ResultSet rs, int arg1) throws SQLException { PolicyUnit policyUnit = new PolicyUnit(); - policyUnit.setId(Guid.createGuidFromString(rs.getString("id"))); + policyUnit.setId(getGuid(rs, "id")); policyUnit.setName(rs.getString("name")); policyUnit.setFilterImplemeted(rs.getBoolean("has_filter")); -- To view, visit http://gerrit.ovirt.org/17046 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib869b2aeabf934913375642a183fb3af64342f9b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
