Martin Sivák has posted comments on this change.
Change subject: agent: Report FQDN of the machine
......................................................................
Patch Set 6: (1 inline comment)
....................................................
File ovirt-guest-agent/OVirtAgentLogic.py
Line 258: logging.debug("Not sending API version. "
Line 259: "API versioning not supported by other
end.")
Line 260:
Line 261: def sendFQDN(self):
Line 262: if self.dr.getAPIVersion() > 0:
I would prefer >=1 here
Line 263: self.vio.write('fqdn', {'fqdn': self.dr.getFQDN()})
Line 264:
Line 265: def sendUserInfo(self, force=False):
Line 266: cur_user = str(self.dr.getActiveUser())
--
To view, visit http://gerrit.ovirt.org/16123
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d91de94b9ebd4448e9761ce597d970029ca3837
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
