Maor Lipchuk has posted comments on this change. Change subject: core: Extract method to be with meaningful name. ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java Line 790: disk.setActive(false); Line 791: setDiskStorageDomainInfo(disk); Line 792: Line 793: diskGuidList.add(disk.getId()); Line 794: imageGuidList.add(disk.getImageId()); thanks for noticing, it belongs to the other patch, will be changed. Line 795: saveImage(disk); Line 796: snapshotId = disk.getVmSnapshotId(); Line 797: saveSnapshotIfNotExists(snapshotId, disk); Line 798: saveDiskImageDynamic(disk); -- To view, visit http://gerrit.ovirt.org/17041 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I610c04760f12c69100814985b201780dfe87c548 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
