Martin Peřina has posted comments on this change.
Change subject: core: Adding unit test for DnsLocator
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/tools/src/test/java/org/ovirt/engine/core/utils/dns/DnsSRVLocatorTest.java
Line 43: @Test(expected = IllegalArgumentException.class)
Line 44: public void testZeroPriorities() throws Exception {
Line 45: DnsSRVLocator locator = mockLocator("example.com",
Line 46: "10 100 389 a.example.com."
Line 47: , "10 100 389 b.example.com."
I would prefer the comma (arguments separator) to be last character on the
previous line than the first one on this line
Line 48: , "10 100 389 c.example.com."
Line 49: , "10 100 389 d.example.com."
Line 50: , "10 100 389 e.example.com."
Line 51: , "10 100 389 f.example.com."
....................................................
Commit Message
Line 8:
Line 9: The purpose of the second test is to cause contract
Line 10: breakage of compareTo, based on data attached to the bug
Line 11: Bug-Url: https://bugzilla.redhat.com/ 985623
Line 12:
Please remove the space from bug-url
Line 13: Change-Id: Ied8ca585b38d624c04b3f232833e1b34ad5dfab5
--
To view, visit http://gerrit.ovirt.org/17048
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied8ca585b38d624c04b3f232833e1b34ad5dfab5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
