Alexander Wels has posted comments on this change.
Change subject: userportal, webadmin: make column width persistent
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/CssUtils.java
Line 27:
Line 28: /**
Line 29: * Append "px" to a CSS length.
Line 30: * @param length a numeric CSS length
Line 31: * @return the length with "px" appended to it, or "auto" if an
invalid number was passed in
I wonder how one could possibly get 'auto' out of this code.
Line 32: */
Line 33: public static String appendPxToCssLength(int length) {
Line 34: return "" + length + "px"; //$NON-NLS-1$ //$NON-NLS-2$
Line 35: }
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java
Line 168: String width = getColumnWidth(tableId, i);
Line 169: width = CssUtils.appendPxToCssLength(width);
Line 170: table.setColumnWidth(column, width);
Line 171: tableHeader.setColumnWidth(column, width);
Line 172: }
This seems like the wrong place to do this, setRowData is fired often, each
time some data changes. I would expect this code to be called when the table is
initialized, not when the data is updated.
Line 173: }
Line 174:
Line 175: @Override
Line 176: protected void onLoadingStateChanged(LoadingState state) {
....................................................
File
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedVirtualMachineView.java
Line 93: protected SimpleActionTable<UserPortalItemModel>
createActionTable() {
Line 94: return new
UserPortalSimpleActionTable<UserPortalItemModel>(modelProvider,
Line 95: getTableResources(),
Line 96: ClientGinjectorProvider.instance().getEventBus(),
Line 97: ClientGinjectorProvider.instance().getClientStorage(),
Hopefully all of this will get refactored in a patch after the
GWT2.5/GIN2.0/GWTP1 patch.
Line 98: new UserPortalRefreshManager(modelProvider,
Line 99:
ClientGinjectorProvider.instance().getEventBus(),
Line 100:
ClientGinjectorProvider.instance().getClientStorage()));
Line 101: }
--
To view, visit http://gerrit.ovirt.org/17118
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I761e12de743fc9b5fce9edf52b929200abe25c8c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
