Yair Zaslavsky has posted comments on this change.
Change subject: [WIP] Introduce new authenticator interface
......................................................................
Patch Set 4: (2 inline comments)
....................................................
File
backend/manager/modules/auth/src/main/java/org/ovirt/engine/core/authenticator/AuthenticatorManager.java
Line 73: private Map<String, AuthenticatorProvider> providersMap =
Line 74: new ConcurrentHashMap<>();
Line 75:
Line 76: // Here we store the instances:
Line 77: private Map<String, Authenticator> instancesMap = new
ConcurrentHashMap<>();
why not just authenticatorsMap?
Line 78: private List<Authenticator> instancesList = new ArrayList<>();
Line 79:
Line 80: /**
Line 81: * Create the singleton.
Line 126: );
Line 127: return;
Line 128: }
Line 129:
Line 130: // Enumerate and load the files in alphabetical order:
Any reason to do so besides logging?
Line 131: File[] files = directory.listFiles();
Line 132: Arrays.sort(files);
Line 133: for (File file : files) {
Line 134: if (file.getName().endsWith(".properties")) {
--
To view, visit http://gerrit.ovirt.org/15597
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I11635c21917401ac7c882fa3233010c804dfb91f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
