ofri masad has posted comments on this change.
Change subject: engine:Trusted Compute Pools - Open Attestation integration
with oVirt engine
......................................................................
Patch Set 3: (4 inline comments)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
Line 634:
severities.put(AuditLogType.USER_UPDATE_VM_CLUSTER_DEFAULT_HOST_CLEARED,
AuditLogSeverity.NORMAL);
Line 635:
severities.put(AuditLogType.IMPORTEXPORT_IMPORT_TEMPLATE_FROM_TRUSTED_TO_UNTRUSTED,
AuditLogSeverity.NORMAL);
Line 636:
severities.put(AuditLogType.IMPORTEXPORT_IMPORT_TEMPLATE_FROM_UNTRUSTED_TO_TRUSTED,
AuditLogSeverity.NORMAL);
Line 637:
severities.put(AuditLogType.IMPORTEXPORT_IMPORT_VM_FROM_TRUSTED_TO_UNTRUSTED,
AuditLogSeverity.NORMAL);
Line 638:
severities.put(AuditLogType.IMPORTEXPORT_IMPORT_VM_FROM_UNTRUSTED_TO_TRUSTED,
AuditLogSeverity.NORMAL);
please change both to "WARNING" instead of "NORMAL"
Line 639: }
Line 640:
Line 641: private static void initTagSeverities() {
Line 642: severities.put(AuditLogType.USER_UPDATE_TAG,
AuditLogSeverity.NORMAL);
....................................................
File
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
Line 526: IMPORTEXPORT_REMOVE_VM_FAILED=Failed to remove Vm ${VmName} remove
from ${StorageDomainName}
Line 527: IMPORTEXPORT_GET_VMS_INFO_FAILED=Failed to retrieve VM/Templates
information from export domain ${StorageDomainName}
Line 528: IMPORTEXPORT_IMPORT_TEMPLATE_FROM_TRUSTED_TO_UNTRUSTED=the Template
${VmTemplateName} was created in trusted cluster and imported into a
non-trusted cluster
Line 529: IMPORTEXPORT_IMPORT_TEMPLATE_FROM_UNTRUSTED_TO_TRUSTED=the Template
${VmTemplateName} was created in non-trusted cluster and imported into a
trusted cluster
Line 530: IMPORTEXPORT_IMPORT_VM_FROM_TRUSTED_TO_UNTRUSTED=the Vm ${VmName} was
created in trusted cluster and imported into a non-trusted cluster
s/the/The
s/Vm/VM
Line 531: IMPORTEXPORT_IMPORT_VM_FROM_UNTRUSTED_TO_TRUSTED=the Vm ${VmName} was
created in non-trusted cluster and imported into a trusted cluster
Line 532: USER_ADD_ROLE_WITH_ACTION_GROUP=Role ${RoleName} was added by
${UserName}
Line 533: USER_ADD_ROLE_WITH_ACTION_GROUP_FAILED=Failed to add role ${RoleName}
Line 534: VDS_ALERT_FENCE_IS_NOT_CONFIGURED=Failed to verify Power Management
configuration for Host ${VdsName}.
Line 527: IMPORTEXPORT_GET_VMS_INFO_FAILED=Failed to retrieve VM/Templates
information from export domain ${StorageDomainName}
Line 528: IMPORTEXPORT_IMPORT_TEMPLATE_FROM_TRUSTED_TO_UNTRUSTED=the Template
${VmTemplateName} was created in trusted cluster and imported into a
non-trusted cluster
Line 529: IMPORTEXPORT_IMPORT_TEMPLATE_FROM_UNTRUSTED_TO_TRUSTED=the Template
${VmTemplateName} was created in non-trusted cluster and imported into a
trusted cluster
Line 530: IMPORTEXPORT_IMPORT_VM_FROM_TRUSTED_TO_UNTRUSTED=the Vm ${VmName} was
created in trusted cluster and imported into a non-trusted cluster
Line 531: IMPORTEXPORT_IMPORT_VM_FROM_UNTRUSTED_TO_TRUSTED=the Vm ${VmName} was
created in non-trusted cluster and imported into a trusted cluster
same
Line 532: USER_ADD_ROLE_WITH_ACTION_GROUP=Role ${RoleName} was added by
${UserName}
Line 533: USER_ADD_ROLE_WITH_ACTION_GROUP_FAILED=Failed to add role ${RoleName}
Line 534: VDS_ALERT_FENCE_IS_NOT_CONFIGURED=Failed to verify Power Management
configuration for Host ${VdsName}.
Line 535: VDS_ALERT_FENCE_TEST_FAILED=Power Management test failed for Host
${VdsName}.${Reason}
....................................................
Commit Message
Line 7: engine:Trusted Compute Pools - Open Attestation integration with oVirt
engine
Line 8:
Line 9: Detailed description: http://wiki.ovirt.org/Trusted_compute_pools
Line 10:
Line 11: Import trusted vm into a untrusted cluster, then make an audit event.
Please change message: "Add Audit log message when importing a vm that was
created in a trusted cluster into a non-trusted cluster and vice-versa"
Line 12:
Line 13: Change-Id: Ib934302c603c8646f750bafbf343e4481b4d36b7
Line 14: Signed-off-by: Jimmy <[email protected]>
--
To view, visit http://gerrit.ovirt.org/16596
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib934302c603c8646f750bafbf343e4481b4d36b7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gang Wei <[email protected]>
Gerrit-Reviewer: Dave Chen <[email protected]>
Gerrit-Reviewer: Emily Zhang <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
