Allon Mureinik has posted comments on this change. Change subject: core:fkvalidator.sh - some args are not honoured ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (2 inline comments) .................................................... File packaging/setup/dbutils/fkvalidator.sh Line 81: } Line 82: Line 83: FIXIT=false Line 84: Line 85: while getopts hs:d:u:l:p:fqv option; do what's the point of this reorg? Line 86: case $option in Line 87: s) SERVERNAME=$OPTARG;; Line 88: p) PORT=$OPTARG;; Line 89: d) DATABASE=$OPTARG;; .................................................... File packaging/setup/dbutils/fkvalidator_sp.sql Line 38: IF (v_fix_it) THEN Line 39: v_sql := 'delete from ' || v_record.fk_table_name || Line 40: ' where ' || v_record.fk_col || 'IS NOT NULL and ' || v_record.fk_col || ' not in (select ' || Line 41: v_record.table_col || ' from ' || v_record.table_name || ');'; Line 42: v_msg := 'Fixing violation/s found in ' || v_record.fk_table_name ; I'd write violation(s) instead of violation/s Line 43: ELSE Line 44: v_sql := 'select ' || v_record.fk_col || ' from ' || v_record.fk_table_name || Line 45: ' where ' || v_record.fk_col || 'IS NOT NULL and ' || v_record.fk_col || ' not in (select ' || Line 46: v_record.table_col || ' from ' || v_record.table_name || ');'; -- To view, visit http://gerrit.ovirt.org/17015 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I759dc11424bda345e14e7bc7bdf81d41515a0847 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
