Daniel Erez has posted comments on this change.

Change subject: core: Serializable LastTimeUsedAsMasterComp
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java
Line 386:     protected void executeInNewTransaction(TransactionMethod<?> 
method) {
Line 387:         TransactionSupport.executeInNewTransaction(method);
Line 388:     }
Line 389: 
Line 390:     private static final class LastTimeUsedAsMasterComp implements 
Comparator<StorageDomain>, Serializable {
please generate serialVersionUID
Line 391:         public static final LastTimeUsedAsMasterComp instance = new 
LastTimeUsedAsMasterComp();
Line 392: 
Line 393:         @Override
Line 394:         public int compare(StorageDomain o1, StorageDomain o2) {


-- 
To view, visit http://gerrit.ovirt.org/17127
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5a30def7a132a7d53a57e57acbf9b61132a9bff6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to