Juan Hernandez has posted comments on this change.
Change subject: [WIP] Replace GetAdUserByUserName with generic interface
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java
Line 36: }
Line 37:
Line 38: private void HandleAuthenticationError(List<VdcBllMessages>
errorMessages) {
Line 39: // If for some reason the error messages list is still empty
then add
Line 40: // the general "user can't authenticate" message:
All this logic is used to check if the password has expired, and it uses the
LdapUser.getPasswordExpired() method, but the corresponding
LdapUser.setPasswordExpired() method is never called, so at the moment this
code doesn't have any effect, thus I removed it.
Line 41: if (errorMessages.size() == 0) {
Line 42:
errorMessages.add(VdcBllMessages.USER_FAILED_TO_AUTHENTICATE);
Line 43: }
Line 44: for (VdcBllMessages msg : errorMessages) {
--
To view, visit http://gerrit.ovirt.org/15758
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If1973d8db07705f7477016845dbd637ad21966c6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
