Alon Bar-Lev has posted comments on this change.
Change subject: vdsm: packages: Fix invoke libvirt configuration command failure
......................................................................
Patch Set 1: (1 inline comment)
Unlike other people out here, I do not need -1 to force to do anything, mark as
-1 only if you feel strongly that a patch should not be proceed.
....................................................
File src/plugins/ovirt-host-deploy/vdsm/packages.py
Line 131: def _reconfigure(self):
Line 132: rc, stdout, stderr = self.execute(
Line 133: (
Line 134: self.command.get('vdsm-tool'),
Line 135: 'libvirt-configure',
as you can see bellow, there was no force.
Line 136: ),
Line 137: raiseOnError=False,
Line 138: )
Line 139: if rc != 0:
--
To view, visit http://gerrit.ovirt.org/17184
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I40c52687f9c2572a30d718f7cd7a62bbc0261c26
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
