Juan Hernandez has posted comments on this change.
Change subject: [WIP] Add temporary LDAP directory provider
......................................................................
Patch Set 6: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/directory/ldap/ProvisionalLdapDirectory.java
Line 79:
Line 80: @Override
Line 81: public Set<DirectoryUser> findUsersById(Set<String> ids) {
Line 82: // Find the users using the old mechanism:
Line 83: ArrayList<Guid> guids = new ArrayList<>(ids.size());
I also like that more, but the LdapSearchByUserIdListParameters constructor
takes ArrayList as parameter. I will see change that:
http://gerrit.ovirt.org/17205
Line 84: for (String id : ids) {
Line 85: Guid guid = new Guid(id);
Line 86: guids.add(guid);
Line 87: }
--
To view, visit http://gerrit.ovirt.org/15638
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc290ba20b447a06d2dda24500ae0d828597bcb6
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
