Ori Liel has posted comments on this change.
Change subject: api: API to prepare VM disk for backup.
......................................................................
Patch Set 2: (3 inline comments)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmDiskResource.java
Line 59:
Line 60: @POST
Line 61: @Formatted
Line 62: @Actionable
Line 63: @Path("prepareForBackup")
path should be all lower-case letter.
Line 64: @Consumes({MediaType.APPLICATION_XML, MediaType.APPLICATION_JSON,
MediaType.APPLICATION_X_YAML})
Line 65: public Response prepareForBackup(Action action);
Line 66:
Line 67: @PUT
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
Line 416: headers:
Line 417: Content-Type: {value: application/xml|json, required: true}
Line 418: Correlation-Id: {value: 'any string', required: false}
Line 419: Filter: {value: true|false, required: false}
Line 420: - name:
/api/vms/{vm:id}/disks/{disk:id}/prepareForBackup|rel=prepareForBackup
lowercase: prepareForBackup --> prepareforbackup
Line 421: request:
Line 422: body:
Line 423: parameterType: Action
Line 424: signatures: []
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResource.java
Line 105: new
PrepareForBackupParameters(((BackendVmDisksResource) collection).parentId,
Line 106: guid);
Line 107: return doAction(VdcActionType.PrepareForBackup, params,
action);
Line 108: }
Line 109:
We should add a test for this flow in BackendVmDiskResourceTest
Line 110: protected Disk getDisk() {
Line 111: return performGet(VdcQueryType.GetDiskByDiskId, new
IdQueryParameters(guid));
Line 112: }
Line 113:
--
To view, visit http://gerrit.ovirt.org/15143
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5c23eef3599fb56606c01cd06354acadb144046
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: liron aravot <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
