Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: avoid traceback adding data domain
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(2 inline comments)
....................................................
File packaging/setup/plugins/ovirt-engine-setup/all-in-one/vdsm.py
Line 247: ))
Line 248: else:
Line 249: self.logger.debug('Adding local storage domain')
Line 250: storage = self._ovirtsdk_xml.params.Storage(
Line 251: path=self.environment[
yes, always prefer kw...
Line 252: osetupcons.AIOEnv.STORAGE_DOMAIN_DIR
Line 253: ].rstrip('/'),
Line 254: )
Line 255: storage.set_type('localfs')
Line 249: self.logger.debug('Adding local storage domain')
Line 250: storage = self._ovirtsdk_xml.params.Storage(
Line 251: path=self.environment[
Line 252: osetupcons.AIOEnv.STORAGE_DOMAIN_DIR
Line 253: ].rstrip('/'),
I think we can keep the comma... :)
Line 254: )
Line 255: storage.set_type('localfs')
Line 256:
Line 257: storage_domain = self._ovirtsdk_xml.params.StorageDomain(
--
To view, visit http://gerrit.ovirt.org/17210
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I617b30d16e0eb28d60a3ce9feb32c47df38eff1d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
