Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: remove legacy setup
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File packaging/bin/engine-upgrade.sh
Line 3: cat >&2 <<__EOF__
Line 4: engine-upgrade is obsoleted
Line 5: please run engine-setup for upgrading package.
Line 6: __EOF__
Line 7:
I do not wish to add gettext complexity in this minor message, especially when
it is only for backward compatibility.
I don't like
echo "
bla bla
"
as in principle quotes and other special chars should be escaped... and I wish
to avoid escapes. why do you think the above is more complex?
--
To view, visit http://gerrit.ovirt.org/17204
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ae205aa17eea390b82fe32be9f517cfb55dbe0f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
