Maor Lipchuk has posted comments on this change.
Change subject: engine: Validate NfsTimeo and NfsRetarns
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageServerConnections.java
Line 159: public void setNfsVersion(NfsVersion nfsVersion) {
Line 160: this.nfsVersion = nfsVersion;
Line 161: }
Line 162:
Line 163: @Min(value = 0, message =
"VALIDATION_STORAGE_CONNECTION_NFS_TIMEO")
or message in the appErrors should indicate 0 as min value (not 1)
Line 164: @Max(value = 6000, message =
"VALIDATION_STORAGE_CONNECTION_NFS_TIMEO")
Line 165: private Short nfsTimeo;
Line 166:
Line 167: public Short getNfsTimeo() {
--
To view, visit http://gerrit.ovirt.org/17182
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I15d35b2547bb36d17e29c90a05854fe6f897d5d2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: A Burden <abur...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Eduardo <ewars...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
